Henrik, Denis,

Can you please review https://github.com/apache/otava/pull/95? This PR
fixes commands in docs and also another bug discovered while verifying that
the fixed commands work as expected.

Best,
Alex

On Mon, Nov 10, 2025 at 5:54 PM Alexander Sorokoumov <
[email protected]> wrote:

> Hey Henrik, Denis,
>
> Thanks for pointing out these issues. I will create a new RC with fixes
> for both.
>
> Best,
> Alex
>
> On Mon, Nov 10, 2025 at 9:36 AM Denis Shchepakin <
> [email protected]> wrote:
>
>> [✓] Download links are valid.
>> [✓] Checksums and signatures.
>> [✓] LICENSE/NOTICE files exist.
>> [✓] No unexpected binary files.
>> [✓] All source files have ASF headers.
>> [✓] Can install from source.
>> *[✗] Can run examples using all supported Python versions.*
>>
>> The examples for postgres, graphite, and graphana seem to be broken (all
>> have extra `otava` or `bin/otava` in their commands):
>>
>>    1. PostgreSQL has: `docker-compose -f
>>    examples/postgresql/docker-compose.yaml run --build otava *bin/otava*
>>    analyze aggregate_mem --update-postgres`
>>    but it should have: `docker-compose -f
>>    examples/postgresql/docker-compose.yaml run --build otava  analyze
>>    aggregate_mem --update-postgres`
>>
>>    2. Graphite's has: `docker-compose -f
>>    examples/graphite/docker-compose.yaml run otava *otava *analyze
>>    my-product.test --since=-10m`
>>    but it should have: `docker-compose -f
>>    examples/graphite/docker-compose.yaml run otava analyze my-product.test
>>    --since=-10m`
>>
>>    3. Grapha's has: `docker-compose -f
>>    examples/graphite/docker-compose.yaml run otava *otava *analyze
>>    my-product.test --since=-10m --update-grafana`
>>    but it should have: `docker-compose -f
>>    examples/graphite/docker-compose.yaml run otava analyze my-product.test
>>    --since=-10m --update-grafana`
>>
>> If typos in docs/examples count as a bug, then I'd call it -1 nb.
>>
>> Best,
>> Denis
>>
>> On Tue, Nov 4, 2025 at 9:44 PM Alexander Sorokoumov <
>> [email protected]> wrote:
>>
>> > Hello everyone,
>> >
>> > Please review and vote for the releasing Apache Otava
>> 0.7.0-incubating-rc2.
>> >
>> > Changelog for this release candidate
>> >
>> >
>> https://github.com/apache/otava/compare/0.6.1-incubating...0.7.0-incubating-rc2
>> > .
>> > The official Apache source release has been deployed to
>> >
>> https://dist.apache.org/repos/dist/dev/incubator/otava/0.7.0-incubating-rc2
>> > .
>> > GH tag for release
>> > https://github.com/apache/otava/releases/tag/0.7.0-incubating-rc2.
>> > The artifacts have been signed with Key [ E81152E1F17593C0949A9D235E
>> > 2C934B6C5147A0 ], corresponding to [email protected] available
>> here
>> > https://dist.apache.org/repos/dist/release/incubator/otava/KEYS.
>> > Please download, verify, and test.
>> >
>> > Please vote on releasing this candidate by replying with:
>> > [ ] +1 Release this package
>> > [ ] 0 No opinion
>> > [ ] -1 Do not release (please provide reason)
>> >
>> > To learn more about Apache Otava, please see https://otava.apache.org.
>> >
>> > This vote will be open for at least 72 hours.
>> >
>> > Checklist for reference:
>> > [ ] Download links are valid.
>> > [ ] Checksums and signatures.
>> > [ ] LICENSE/NOTICE files exist.
>> > [ ] No unexpected binary files.
>> > [ ] All source files have ASF headers.
>> > [ ] Can install from source.
>> > [ ] Can run examples using all supported Python versions.
>> >
>> > Best,
>> > Alex
>> >
>>
>

Reply via email to