-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi otrs-dev,

I've had a look the package TimeAccounting 1.0.1 and so far I've
encountered some trouble. Apparently there are some bugs in the package.
Maybe some of them only occur while using PostgreSQL (don't know about
the tolerance of MySQL)... anyway, this is what I've figured out:


(1) Kernel::System::TimeAccounting line 568:
        $Param{$_} = $Self->{DBObject}->Quote($Param{$_}) || '';

...this is a problem when the value before the OR is 0 the assignment is
evaluated to false and the empty string 'wins' the assignment. This
causes trouble when inserting a NULL value into integer or numeric
coloumns in DB-tables. Better would be something like that (IMO... at
least it works for me ;)):

        $Param{$_} = $Self->{DBObject}->Quote($Param{$_});
        if( !defined($Param{$_})) {
                $Param{$_} = '';
        }

The problem reappears in sub UserSettingsUpdate.


(2) Kernel::System::TimeAccounting line 595 and following: the column
'DESCRIPTION' which is set to NOT NULL, is ommited. This statement is
not accepted by the data base. The initial configuration doesn'T allow
to give a description anyway. So my workaround is

        => use of a default user description for the initial insert
        => and (of course) completion of the SQL-statement in line 595


(3) Kernel::Modules::AgentTimeAccounting 245:
        $Data{$WorkingUnitID}{Period}    =  '';

...better would be:
        $Data{$WorkingUnitID}{Period}    = 'NULL';

I'd have created an entry in bugs.otrs.org if there was an option for
the TimeAccounting module. So I just put it here :)


regards, Torsten Thau

- --
Torsten Thau, Dipl. Inform.
c.a.p.e. IT Labs GbR - Annaberger Str. 240 - D-09125 Chemnitz
phone: +49 371 5347 623
cell: +49 176 66 680 680
pgp-key: 0x292F987D
fax: +49 371 5347 625
http://www.cape-it.de
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFGVEfgvXo8m5PgoXQRAttgAJsFxDrQedhDJYrwXLYvGa+v/p2eqACeOZLH
4z0X30CzQA/7M/b1LrAz1d8=
=QgwY
-----END PGP SIGNATURE-----
_______________________________________________
OTRS mailing list: dev - Webpage: http://otrs.org/
Archive: http://lists.otrs.org/pipermail/dev
To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev

Reply via email to