Thanks for working on this, I tried out the rewrite CLI with/without modifying the key and it works. +1 for the merge.
Just curious as to what happens to the original key blocks. Do we intend to clean it up? If the answer is yes, having snapshots can cause trouble here as it would refer to older blocks. On Tue, Jun 25, 2024 at 7:18 PM Stephen O'Donnell <[email protected]> wrote: > +1 for the merge from me. Disclaimer - I was involved in the changes on > this branch. > > Thanks, > > Stephen. > > On Tue, Jun 25, 2024 at 1:32 PM Attila Doroszlai <[email protected]> > wrote: > > > Hi Ozone developers, > > > > I would like to propose merging into master the feature branch > > HDDS-10656-atomic-key-overwrite, which was used to develop Atomic Key > > Overwrite. > > > > There are scenarios where it would be desirable to replace a key in > > Ozone, but only if the key has not changed since it was read. The > > commits in the branch implement a minimal change to allow this feature > > in the Ozone API. > > > > Checklist for feature branch merge: > > > > > https://cwiki.apache.org/confluence/display/OZONE/Atomic+Key+Overwrite+and+Key+Replacement+-+HDDS-10656 > > > > This vote will be open for at least a week. > > > > thanks, > > Attila > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > >
