jmarantz commented on a change in pull request #1695: 
OutputSanitizingAsyncFetch: runs right before PSOL responds
URL: 
https://github.com/apache/incubator-pagespeed-mod/pull/1695#discussion_r160147479
 
 

 ##########
 File path: pagespeed/apache/header_util.cc
 ##########
 @@ -115,6 +115,9 @@ void AddResponseHeadersToRequestHelper(const 
ResponseHeaders& response_headers,
   for (int i = 0, n = response_headers.NumAttributes(); i < n; ++i) {
     const GoogleString& name = response_headers.Name(i);
     const GoogleString& value = response_headers.Value(i);
+    if (strings::StartsWith(name, "@")) {
+      continue;
 
 Review comment:
   curious: does this get hit in tests?  the concerning thing here is whether 
there's something linking through PSOL into the integrations that we have to 
catch on each integration.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to