eldk commented on issue #1763: Ubuntu 16.04 : make apache_install_conf fails URL: https://github.com/apache/incubator-pagespeed-mod/issues/1763#issuecomment-380442031 Hello, make apache_test : Making this change : replace PURGE request with GET one, I got the expected behavior : Apache gives a 200 response. ``` --- a/pagespeed/system/serf_url_async_fetcher_test.cc +++ b/pagespeed/system/serf_url_async_fetcher_test.cc @@ -462,7 +462,7 @@ TEST_F(SerfUrlAsyncFetcherTest, FetchOneURL) { // Tests that when the fetcher requests using a different request method, // PURGE in this case, it gets the expected response. TEST_F(SerfUrlAsyncFetcherTest, FetchUsingDifferentRequestMethod) { - request_headers(kModpagespeedSite)->set_method(RequestHeaders::kPurge); + request_headers(kModpagespeedSite)->set_method(RequestHeaders::kGet); StartFetches(kModpagespeedSite, kModpagespeedSite); ASSERT_EQ(1, WaitTillDone(kModpagespeedSite, kModpagespeedSite)); ASSERT_TRUE(fetches_[kModpagespeedSite]->IsDone()); ``` ``` [ RUN ] SerfUrlAsyncFetcherTest.FetchUsingDifferentRequestMethod pagespeed/system/serf_url_async_fetcher_test.cc:471: Failure ``` ``` Value of: response_headers(kModpagespeedSite)->status_code() Actual: 200 ``` ``` Expected: 501 pagespeed/system/serf_url_async_fetcher_test.cc:475: Failure Value of: contents(kModpagespeedSite).find( "PURGE to /mod_pagespeed_example/index.html not supported.") != GoogleString::npos Actual: false Expected: true pagespeed/system/serf_url_async_fetcher_test.cc:316: Failure Value of: statistics_->GetVariable( SerfStats::kSerfFetchUltimateSuccess)->Get() Actual: 1 Expected: expect_success Which is: 0 pagespeed/system/serf_url_async_fetcher_test.cc:318: Failure Value of: statistics_->GetVariable( SerfStats::kSerfFetchUltimateFailure)->Get() Actual: 0 Expected: expect_failure Which is: 1 [ FAILED ] SerfUrlAsyncFetcherTest.FetchUsingDifferentRequestMethod (499 ms) ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
