oschaaf commented on issue #1352: resize_rendered_image_dimensions example 
behaves odd
URL: 
https://github.com/apache/incubator-pagespeed-mod/issues/1352#issuecomment-381978777
 
 
   If `PrepareForBeaconInsertionHelper()` [1] has determined we should beacon, 
the filter that drives the actual rendering of resized images should back off 
of making any changes, to avoid the beacon reporting the original dimensions as 
the resized ones. I have yet to figure out where to exactly do that.
   
   [1] 
https://github.com/apache/incubator-pagespeed-mod/blob/c78d8e85622fe8d451ef29d21f89c68f21067fe6/net/instaweb/rewriter/critical_finder_support_util.cc#L345

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to