edeis53 commented on issue #1704: Redis cache TTL
URL: 
https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387212216
 
 
   Essentially, all that should be required is swapping the SET command with 
SETEX, and defining a default for the TTL to -1 (no expiry). Then defining a 
ModPagespeedRedisTtl in config.
   
   SETEX keyname ttltime value
   https://redis.io/commands/setex
   
   /pagespeed/system/redis_cache.cc
   ```
   void RedisCache::Put(const GoogleString& key, const SharedString& value) {
     RedisReply reply = RedisCommand(
         LookupConnection(key),
         "SET %b %b",
         {REDIS_REPLY_STATUS},
   ```
   
   I'd submit a pull, but have no experience in c++
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to