jmarantz commented on issue #1704: Redis cache TTL
URL: 
https://github.com/apache/incubator-pagespeed-mod/issues/1704#issuecomment-387400092
 
 
   @oschaaf thanks for pulling up the example.  I missed in the PR review that 
the DB-index is not in the map key.  I think it needs to be incorporated here:
   ```
       spec_signature =
           StrCat("r;", config->redis_server().ToString(), ";",
                  IntegerToString(config->redis_reconnection_delay_ms()), ";",
                  IntegerToString(config->redis_timeout_us()));
   ```
   So if two different VirtualHosts construct redis caches that differ only 
DB-index then the first one will win.  I added this as a separate issue: 
https://github.com/apache/incubator-pagespeed-mod/issues/1771

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to