jmarantz commented on a change in pull request #1802: Prefer Paint Timing API
over chrome.loadTimes()
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1802#discussion_r224992690
##########
File path: net/instaweb/rewriter/add_instrumentation.js
##########
@@ -95,6 +95,12 @@ pagespeed.AddInstrumentation.prototype.sendBeacon =
function() {
if (timingApi['msFirstPaint']) {
// IE.
firstPaintTime = timingApi['msFirstPaint'];
+ } else if (window['performance']['timeOrigin'] &&
+ window['performance']['getEntriesByName']('first-paint').length > 0) {
+ // Paint Timing API
+ firstPaintTime = Math.floor(
+ window.performance.timeOrigin +
Review comment:
Use the ['xxx'] notation rather than .xxx as above. This is important
because the Closure Compiler may rename these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
