injust commented on a change in pull request #1802: Prefer Paint Timing API over chrome.loadTimes() URL: https://github.com/apache/incubator-pagespeed-mod/pull/1802#discussion_r225034179
########## File path: net/instaweb/rewriter/add_instrumentation.js ########## @@ -71,11 +71,11 @@ pagespeed.AddInstrumentation.prototype.sendBeacon = function() { } url += '&r' + this.event_ + '='; - if (window['performance']) { - var timingApi = window['performance']['timing']; + if (winPerf = window['performance']) { Review comment: Right, oops. It compiles, but bad practice to use undeclared variables. Sorry! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services