BVMiko commented on issue #1743: Cache-Control header values are not always treated case-insensitive as the spec indicates URL: https://github.com/apache/incubator-pagespeed-mod/issues/1743#issuecomment-495723424 This issue extends beyond the caching request headers for HTTP/1.1.See https://tools.ietf.org/html/rfc7230#section-3.2 > Each header field consists of a case-insensitive field name followed by a colon (":"), optional leading whitespace, the field value, and optional trailing whitespace. Also, it looks as though _all_ headers will need to be lowercase to be compliant with the new HTTP/2 spec: https://tools.ietf.org/html/rfc7540#section-8.1.2 > Just as in HTTP/1.x, header field names are strings of ASCII characters that are compared in a case-insensitive fashion. However, header field names MUST be converted to lowercase prior to their encoding in HTTP/2. A request or response containing uppercase header field names MUST be treated as malformed (Section 8.1.2.6). --- I'm currently running into an issue due to the case-sensitive check for the `PageSpeed: off` header. The case-sensitive checks for `PageSpeed*` headers seem to be handled with this function: https://github.com/apache/incubator-pagespeed-mod/blob/b4bf44cc56d8bbf17494c540dfb6ef20dfcf5073/net/instaweb/rewriter/rewrite_query.cc#L87
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
