oschaaf commented on issue #1899: data-srcset in img and amp-img
URL: 
https://github.com/apache/incubator-pagespeed-mod/pull/1899#issuecomment-503605634
 
 
   @jmarantz re: testing
   
   CI runs 
[build_release.sh](https://github.com/apache/incubator-pagespeed-mod/blob/master/install/build_release.sh):
   - This runs `pagespeed_automatic_test` and `mod_pagespeed_test` in various 
configurations.
   - Then it builds the mod_pagespeed package, installs it, and runs the system 
tests in multiple configurations
   
   RE: data-srcset
   I'm +1 on as-is regarding `data-srcset`. 
   
   @Lofesa this LGTM, but I think we can condense/simplify the code a bit. That 
would be great to include before merging this. Let's sync up on Slack to get 
that sorted. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to