For the records, found the commit where I changed this: https://github.com/apache/incubator-pagespeed-mod/commit/e357da4779391aa9c00ce41f3db4b468865e7ce6 The commit resides both on the master and bazel branches.
On Fri, May 29, 2020 at 7:45 PM Joshua Marantz <jmara...@google.com.invalid> wrote: > That's my guess too. If you are verifying your source build works from an > isolated machine, feel free to ignore this particular test, and there are > probably a handful of others that require internet access, but you should > be able to get confidence in all the others. > > > On Fri, May 29, 2020 at 1:42 PM Otto van der Schaaf <osch...@we-amp.com> > wrote: > > > I remember fixing that test at some point, it might not be on the master > > branch and just exist > > on the bazel branch, I can't remember. > > I think this failure is safe to ignore. > > The failing test has an expectation that used to match, but no longer > does, > > because the test target > > has changed its response (https://about.google/intl/en/ > > < > > > https://about.google/intl/en/%5B0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > > > > ) > > > > Otto > > > > On Fri, May 29, 2020 at 2:19 PM sales extico <sa...@extico.com> wrote: > > > > > > > > [ RUN ] SerfUrlAsyncFetcherTest.TestHttpsSucceedsForGoogleCom > > > [0529/171353:ERROR:serf_url_async_fetcher_test.cc(285)] Serf retrying > > > flaky url https://about.google/intl/en/ > > > [0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > > < > > > https://about.google/intl/en/%5B0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > >] > > > Serf retrying flaky url https://about.google/intl/en/ > > > [0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > > < > > > https://about.google/intl/en/%5B0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > >] > > > Serf retrying flaky url https://about.google/intl/en/ > > > [0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > > < > > > https://about.google/intl/en/%5B0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > >] > > > Serf retrying flaky url https://about.google/intl/en/ > > > [0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > > < > > > https://about.google/intl/en/%5B0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > >] > > > Serf retrying flaky url https://about.google/intl/en/ > > > [0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > > < > > > https://about.google/intl/en/%5B0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > >] > > > Serf retrying flaky url https://about.google/intl/en/ > > > [0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > > < > > > https://about.google/intl/en/%5B0529/171353:ERROR:serf_url_async_fetcher_test.cc(285) > > >] > > > Serf retrying flaky url https://about.google/intl/en/ > > > [0529/171354:ERROR:serf_url_async_fetcher_test.cc(285) > > > < > > > https://about.google/intl/en/%5B0529/171354:ERROR:serf_url_async_fetcher_test.cc(285) > > >] > > > Serf retrying flaky url https://about.google/intl/en/ > > > [0529/171354:ERROR:serf_url_async_fetcher_test.cc(285) > > > < > > > https://about.google/intl/en/%5B0529/171354:ERROR:serf_url_async_fetcher_test.cc(285) > > >] > > > Serf retrying flaky url https://about.google/intl/en/ > > > [0529/171354:ERROR:serf_url_async_fetcher_test.cc(285) > > > < > > > https://about.google/intl/en/%5B0529/171354:ERROR:serf_url_async_fetcher_test.cc(285) > > >] > > > Serf retrying flaky url https://about.google/intl/en/ > > > pagespeed/system/serf_url_async_fetcher_test.cc:409 > > > < > > > https://about.google/intl/en/pagespeed/system/serf_url_async_fetcher_test.cc:409 > > >: > > > Failure > > > Value of: contents(index).empty() > > > Actual: true > > > Expected: false > > > pagespeed/system/serf_url_async_fetcher_test.cc:410: Failure > > > Value of: response_headers(index)->status_code() > > > Actual: 404 > > > Expected: HttpStatus::kOK > > > Which is: 200 > > > pagespeed/system/serf_url_async_fetcher_test.cc:412: Failure > > > Value of: statistics_->GetVariable( > > SerfStats::kSerfFetchCertErrors)->Get() > > > Actual: 11 > > > Expected: 0 > > > pagespeed/system/serf_url_async_fetcher_test.cc:414: Failure > > > Value of: contents(index).substr(0, content_starts_[index].size()) > > > Actual: "" > > > Expected: content_starts_[index] > > > Which is: "<!DOCTYPE html>" > > > pagespeed/system/serf_url_async_fetcher_test.cc:316: Failure > > > Value of: statistics_->GetVariable( > > > SerfStats::kSerfFetchUltimateSuccess)->Get() > > > Actual: 0 > > > Expected: expect_success > > > Which is: 1 > > > pagespeed/system/serf_url_async_fetcher_test.cc:318: Failure > > > Value of: statistics_->GetVariable( > > > SerfStats::kSerfFetchUltimateFailure)->Get() > > > Actual: 11 > > > Expected: expect_failure > > > Which is: 0 > > > [ FAILED ] SerfUrlAsyncFetcherTest.TestHttpsSucceedsForGoogleCom > (1313 > > > ms) > > > > > > Could you have me check what to do with this? Thank you very much. > > >
