oschaaf commented on a change in pull request #1998:
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/1998#discussion_r459422823
##########
File path: net/instaweb/rewriter/process_context.cc
##########
@@ -58,7 +58,7 @@ ProcessContext::ProcessContext()
// url/url_util.cc lazily initializes its "standard_schemes" table in a
// thread-unsafe way and so it must be explicitly initialized prior to thread
// creation, and explicitly terminated after thread quiescence.
- url::Initialize();
+ //url::Initialize();
Review comment:
From what I understood there's now a method to "freeze" modifying the
scheme registry. If we want to be pedantic we could call that here to ensure
no-one attempts to modify this registry scheme later in a potentially thread
unsafe manner. (But we're not using that functionality).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
