oschaaf commented on pull request #2033:
URL:
https://github.com/apache/incubator-pagespeed-mod/pull/2033#issuecomment-675698612
All unit tests succeed on my dev machine.
As far as I can tell, there are no direct unit-tests for the methods
involved here.
But there are a bunch of tests hitting them by proxy (e.g. for the hasher,
some image utils),
and these don't seem to mind this change. Hopefully Travis will confirm as
well in about half an hour.
It would be good to get the system tests up and running for additional
functional coverage.
Maybe, upon installing a major version (like what's in progress here), we
should completely bust the cache
upon install?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
