oschaaf commented on issue #2041: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2041#issuecomment-704802951
Thanks @ajconejo it is helpful to know that the problem persists with 1.14. One more thought: I just remembered that on master I added https://github.com/apache/incubator-pagespeed-mod/commit/1cc142ecca589964348d059bc2ef8203ecd7961d I did so after a [tsan](https://github.com/google/sanitizers) test run pointed this out as potentially problematic, but it was only caught recently on master as there we have an easy means to test with that sanitiser and others. I'm not sure this is a fix for this specific problem, but it very well might be if tsan was right about the race it observed being problematic in practice. Unfortunately, master diverges quite a bit from 1.14, and there's no packing scripts yet to make it low friction to build/test it, though one can produce an optimized build of mod-pagespeed's lib via: ``` bazel build -c opt libmod_pagespeed.so ``` This may take quite a while, and before doing this one needs a few build time prerequisites. It's probably easiest to take a look at https://github.com/apache/incubator-pagespeed-mod/blob/master/.travis.yml to extract those. I would be curious if the problem persists there too. I wouldn't know how to patch in the change above using the build system for 1.14 as they diverge a lot (gyp vs bazel), hence back porting it doesn't seem straight forward to me at the moment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
