oschaaf commented on issue #1380: URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1380#issuecomment-763210833
@zz9pzza seems relevant to this issue, sure. Apparently the tweak to bump the buffer sizes associated to the pipe didn't help in your case, so it sounds like a proper fix for the TODO over at https://github.com/apache/incubator-pagespeed-ngx/blob/master/src/ngx_event_connection.cc#L157 is necessary. It's been a while, so my memory isn't crystal clear, but I think the that when `NgxEventConnection` runs into the situation where it repeatedly cannot write, a change is needed: - A queue to buffer writes (ordering is important) - A timer, to ensure processing events in the flow when there are no subsequent i/o wakeups The code that now writes to the pipe should first check the queue and process any buffered writes, and then proceed as normal (though possibly disarming the timer if the queue was fully drained ). Similarly the new code associated to the new timer event should also processes buffered up writes. Unfortunately I don't tink I will have time soon to make this happen, but maybe the braindump above will enthuse someone to write a fix, or else it might serve as a note to future me :-) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
