eilandert commented on issue #2069: URL: https://github.com/apache/incubator-pagespeed-mod/issues/2069#issuecomment-971650205
@Lofesa I think we need to include the logging.h from the glog package. @acachy: My approach is not to include /root/.bazel/* but to create a psol.tar.gz package with the libautomatic.a and the needed headers so people can untar it in nginx-1.21.4/modules/ngx_pagespeed/psol without the need to build it with bazel. See the rsync commands in https://github.com/eilandert/psol-bazel/blob/master/docker/build.sh My approach is: 1) create a functional psol (done, I suppose) 2) create a psol.tar.gz with lib+headers (done, I suppose) 3) clone the ngx pagespeed module and make some changes. When 3 works we have a proof of concept. Then we continue to: 4) adjust master/pagespeed/automatic/BUILD and stuff so everything will be build by "bazel build -c fastbuild //pagespeed/automatic:automatic" or something. 5) find out the bazel way to build libicu. When I build ICU with bazel, the build fails because gURL wants to build a target that doesn;t exist. 6) optimize the build. not everything has to be in the lib I think. the lib is around 111MB now, while in the old way it was only half of that. 7) do a pull request I think it is not that difficult, but since I am no dev I have to find everything out for myself with common sense, and currently I haven't got the time. I'm not home for a couple of weeks, i've been sent to a hospital far away due to covid to help out (i am actually an healthcare provider) So, it will take time ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pagespeed.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
