[
https://issues.apache.org/jira/browse/PARQUET-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205986#comment-16205986
]
Zoltan Ivanfi edited comment on PARQUET-1065 at 10/16/17 3:57 PM:
------------------------------------------------------------------
Unfortunately, since INT96 timestamps are stored in little endian order, the
first byte will store the least significant byte of the timestamp and not the
most significant one. For this reason, the value of the first byte will wildly
vary, spanning the whole range between 0x00 and 0xFF. As a result, when
comparing the raw bytes, signed and unsigned comparison can lead to different
results.
EDIT: Actually, although INT96 timestamps have nanosecond precision, most of
the time they are used to store less precise timestamps (e.g., sec, millisec or
microsec). In these cases, the least significant byte is always 0x00, so
comparison signedness does not affect the order. The problem I described above
is only present when the INT96 timestamp precision is utilized to its full
extent, which may be a negligible fraction of all use cases. Still, the
possibility is there.
was (Author: zi):
Unfortunately, since INT96 timestamps are stored in little endian order, the
first byte will store the least significant byte of the timestamp and not the
most significant one. For this reason, the value of the first byte will wildly
vary, spanning the whole range between 0x00 and 0xFF. As a result, when
comparing the raw bytes, signed and unsigned comparison can lead to different
results.
EDIT: Actually, although INT96 timestamps have nanosecond precision, most of
the time they are used to store less precise timestamps (sec, millisec or
microsec). In these cases, the least significant byte is always 0x00, so
comparison signedness does not affect the order. The problem I described above
is only present when the INT96 timestamp precision is used to its full extent,
which may be a negligible fraction of all use cases. Still, the possibility is
there.
> Deprecate type-defined sort ordering for INT96 type
> ---------------------------------------------------
>
> Key: PARQUET-1065
> URL: https://issues.apache.org/jira/browse/PARQUET-1065
> Project: Parquet
> Issue Type: Bug
> Reporter: Zoltan Ivanfi
> Assignee: Zoltan Ivanfi
>
> [parquet.thrift in
> parquet-format|https://github.com/apache/parquet-format/blob/041708da1af52e7cb9288c331b542aa25b68a2b6/src/main/thrift/parquet.thrift#L37]
> defines the the sort order for INT96 to be signed.
> [ParquetMetadataConverter.java in
> parquet-mr|https://github.com/apache/parquet-mr/blob/352b906996f392030bfd53b93e3cf4adb78d1a55/parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java#L422]
> uses unsigned ordering instead. In practice, INT96 is only used for
> timestamps and neither signed nor unsigned ordering of the numeric values is
> correct for this purpose. For this reason, the INT96 sort order should be
> specified as undefined.
> (As a special case, min == max signifies that all values are the same, and
> can be considered valid even for undefined orderings.)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
