[
https://issues.apache.org/jira/browse/PARQUET-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286489#comment-16286489
]
ASF GitHub Bot commented on PARQUET-1175:
-----------------------------------------
wesm closed pull request #423: PARQUET-1175: Fix arrow::ArrayData method rename
from ShallowCopy to Copy
URL: https://github.com/apache/parquet-cpp/pull/423
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cmake_modules/ThirdpartyToolchain.cmake
b/cmake_modules/ThirdpartyToolchain.cmake
index 13ece431..52ab7a8d 100644
--- a/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cmake_modules/ThirdpartyToolchain.cmake
@@ -366,7 +366,7 @@ if (NOT ARROW_FOUND)
-DARROW_BUILD_TESTS=OFF)
if ("$ENV{PARQUET_ARROW_VERSION}" STREQUAL "")
- set(ARROW_VERSION "fc4e2c36d2c56a8bd5d1ab17eeb406826924d3e5")
+ set(ARROW_VERSION "501d60e918bd4d10c429ab34e0b8e8a87dffb732")
else()
set(ARROW_VERSION "$ENV{PARQUET_ARROW_VERSION}")
endif()
diff --git a/src/parquet/arrow/reader.cc b/src/parquet/arrow/reader.cc
index e13a094d..dd60d29b 100644
--- a/src/parquet/arrow/reader.cc
+++ b/src/parquet/arrow/reader.cc
@@ -868,7 +868,7 @@ struct TransferFunctor<
if (type->id() == ::arrow::Type::STRING) {
// Convert from BINARY type to STRING
- auto new_data = (*out)->data()->ShallowCopy();
+ auto new_data = (*out)->data()->Copy();
new_data->type = type;
*out = ::arrow::MakeArray(new_data);
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Fix usage of deprecated Arrow API
> ---------------------------------------
>
> Key: PARQUET-1175
> URL: https://issues.apache.org/jira/browse/PARQUET-1175
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Reporter: Wes McKinney
> Fix For: cpp-1.4.0
>
>
> {code}
> FAILED: CMakeFiles/parquet_objlib.dir/src/parquet/arrow/reader.cc.o
> ccache /usr/bin/clang++-4.0 -DHAVE_INTTYPES_H -DHAVE_NETDB_H
> -DHAVE_NETINET_IN_H -I../src -isystem /home/wesm/cpp-toolchain/include
> -isystem /home/wesm/cpp-toolchain/include/thrift -isystem
> /home/wesm/local/include -Werror -DARROW_NO_DEPRECATED_API -ggdb -O0
> -fno-strict-aliasing -Wall -Qunused-arguments -g -fPIC -fPIC -std=gnu++11
> -MD -MT CMakeFiles/parquet_objlib.dir/src/parquet/arrow/reader.cc.o -MF
> CMakeFiles/parquet_objlib.dir/src/parquet/arrow/reader.cc.o.d -o
> CMakeFiles/parquet_objlib.dir/src/parquet/arrow/reader.cc.o -c
> ../src/parquet/arrow/reader.cc
> ../src/parquet/arrow/reader.cc:871:39: error: no member named 'ShallowCopy'
> in 'arrow::ArrayData'
> auto new_data = (*out)->data()->ShallowCopy();
> ~~~~~~~~~~~~~~ ^
> 1 error generated.
> [15/25] Building CXX object
> CMakeFiles/parquet_objlib.dir/src/parquet/file/metadata.cc.o
> ninja: build stopped: subcommand failed.
> [7/12] Building CXX object
> CMakeFiles/parquet_objlib.dir/src/parquet/arrow/reader.cc.o
> FAILED: CMakeFiles/parquet_objlib.dir/src/parquet/arrow/reader.cc.o
> ccache /usr/bin/clang++-4.0 -DHAVE_INTTYPES_H -DHAVE_NETDB_H
> -DHAVE_NETINET_IN_H -I../src -isystem /home/wesm/cpp-toolchain/include
> -isystem /home/wesm/cpp-toolchain/include/thrift -isystem
> /home/wesm/local/include -Werror -DARROW_NO_DEPRECATED_API -ggdb -O0
> -fno-strict-aliasing -Wall -Qunused-arguments -g -fPIC -fPIC -std=gnu++11
> -MD -MT CMakeFiles/parquet_objlib.dir/src/parquet/arrow/reader.cc.o -MF
> CMakeFiles/parquet_objlib.dir/src/parquet/arrow/reader.cc.o.d -o
> CMakeFiles/parquet_objlib.dir/src/parquet/arrow/reader.cc.o -c
> ../src/parquet/arrow/reader.cc
> ../src/parquet/arrow/reader.cc:871:39: error: no member named 'ShallowCopy'
> in 'arrow::ArrayData'
> auto new_data = (*out)->data()->ShallowCopy();
> ~~~~~~~~~~~~~~ ^
> 1 error generated.
> [8/12] Building CXX object
> CMakeFiles/parquet_objlib.dir/src/parquet/parquet_types.cpp.o
> ninja: build stopped: subcommand failed.
> ~/code/arrow/python ~/code/parquet-cpp/library-build ~/code/arrow/python
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
