[
https://issues.apache.org/jira/browse/PARQUET-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094327#comment-17094327
]
ASF GitHub Bot commented on PARQUET-1850:
-----------------------------------------
prakharjain09 commented on a change in pull request #789:
URL: https://github.com/apache/parquet-mr/pull/789#discussion_r416463221
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
##########
@@ -480,6 +480,10 @@ private void addRowGroup(ParquetMetadata parquetMetadata,
List<RowGroup> rowGrou
columnMetaData.getTotalSize(),
columnMetaData.getFirstDataPageOffset());
columnChunk.meta_data.dictionary_page_offset =
columnMetaData.getDictionaryPageOffset();
Review comment:
Use setDictionary_page_offset instead of
`columnChunk.meta_data.dictionary_page_offset =`. That will automatically
invoke setDictionary_page_offsetIsSet and we don't need to call it explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> toParquetMetadata method in ParquetMetadataConverter does not set dictionary
> page offset bit
> --------------------------------------------------------------------------------------------
>
> Key: PARQUET-1850
> URL: https://issues.apache.org/jira/browse/PARQUET-1850
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr
> Affects Versions: 1.10.1, 1.12.0
> Reporter: Srinivas S T
> Priority: Major
> Fix For: 1.12.0
>
>
> toParquetMetadata method converts
> org.apache.parquet.hadoop.metadata.ParquetMetadata to
> org.apache.parquet.format.FileMetaData but this does not set the dictionary
> page offset bit in FileMetaData.
> When a FileMetaData object is serialized while writing to the footer and then
> deserialized, the dictionary offset is lost as the dictionary page offset bit
> was never set.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
