[
https://issues.apache.org/jira/browse/PARQUET-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219049#comment-17219049
]
ASF GitHub Bot commented on PARQUET-1922:
-----------------------------------------
gszadovszky commented on a change in pull request #825:
URL: https://github.com/apache/parquet-mr/pull/825#discussion_r510205081
##########
File path:
parquet-column/src/main/java/org/apache/parquet/column/values/plain/PlainValuesWriter.java
##########
@@ -127,7 +127,6 @@ public void reset() {
@Override
public void close() {
arrayOut.close();
- out.close();
Review comment:
I am fine fixing this in another ticket. What I think is a key in this
change is to put the related comments (`out.close` is not required because...)
in the code as well as in this review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate IOExceptionUtils
> --------------------------
>
> Key: PARQUET-1922
> URL: https://issues.apache.org/jira/browse/PARQUET-1922
> Project: Parquet
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
