[
https://issues.apache.org/jira/browse/PARQUET-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286958#comment-17286958
]
ASF GitHub Bot commented on PARQUET-1984:
-----------------------------------------
fschmalzel commented on a change in pull request #870:
URL: https://github.com/apache/parquet-mr/pull/870#discussion_r579050976
##########
File path:
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestInputFormat.java
##########
@@ -398,7 +399,10 @@ public void testGetFootersReturnsInPredictableOrder()
throws IOException {
if (i > 0) {
url.append(',');
}
- url.append("file:").append(file.getAbsolutePath());
+ if (!SystemUtils.IS_OS_WINDOWS) {
+ url.append("file:");
+ }
+ url.append(file.getAbsolutePath());
Review comment:
I've changed this test to use URIs instead. Now it should work platform
independent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Some tests fail on windows
> --------------------------
>
> Key: PARQUET-1984
> URL: https://issues.apache.org/jira/browse/PARQUET-1984
> Project: Parquet
> Issue Type: Bug
> Components: parquet-mr, parquet-thrift
> Affects Versions: 1.12.0
> Environment: Windows 10
> Reporter: Felix Schmalzel
> Priority: Minor
>
> Reasons:
> * Expecting \n and getting \r\n
> * Unclosed streams preventing a temporary file from being deleted
> * File layout differences \ and /
> * No native library for brotli, because the brotli-codec dependency only
> shadows macos and linux native libraries.
>
> I've already developed a patch that would fix all the problems excluding the
> brotli one. For that one we would have to wait until this
> [https://github.com/rdblue/brotli-codec/pull/2] request is merged. I will
> link the merge request for the other problems in the next few days.
> Is there a related ticket that i have overlooked?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
