zhongyujiang commented on PR #1028: URL: https://github.com/apache/parquet-mr/pull/1028#issuecomment-1432572977
I haven't encountered any troubles caused by this situation in practice. I found this while looking at the code, when evaluating `notIn`, dictionary filter returns `BLOCK_MIGHT_MATCH` when the column isn't in the file which means all values are null(see L450-L453), but it does not consider whether there will be a null value when the column really exists. I think it's inconsistent so opened this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
