parthchandra commented on code in PR #1032:
URL: https://github.com/apache/parquet-mr/pull/1032#discussion_r1114670273
##########
parquet-common/src/main/java/org/apache/parquet/bytes/CapacityByteArrayOutputStream.java:
##########
@@ -164,6 +164,15 @@ public CapacityByteArrayOutputStream(int initialSlabSize,
int maxCapacityHint, B
private void addSlab(int minimumSize) {
int nextSlabSize;
+ // check for overflow
+ try {
+ Math.addExact(bytesUsed, minimumSize);
+ } catch (ArithmeticException e) {
+ // This is interpreted as a request for a value greater than
Integer.MAX_VALUE
+ // We throw OOM because that is what java.io.ByteArrayOutputStream also
does
+ throw new OutOfMemoryError("Size of data exceeded 2GB (" +
e.getMessage() + ")");
Review Comment:
The exception thrown by Math.exact will happen only if integer overflow
occurs which happens when the data exceeds 2GB (i.e greater than
`Integer.MAX_VALUE` ).
What message were you thinking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
