gszadovszky commented on code in PR #1139:
URL: https://github.com/apache/parquet-mr/pull/1139#discussion_r1329973062
##########
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestParquetFileWriter.java:
##########
@@ -89,10 +89,13 @@
import org.apache.parquet.hadoop.example.GroupWriteSupport;
import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
import org.mockito.Mockito;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+@RunWith(Parameterized.class)
public class TestParquetFileWriter {
Review Comment:
It make sense, thanks. However, it is a bit misleading to me to set the
vector IO related config for the writer as well. What do you think about
separate the `Configuration` instances for the writer and the reader and only
enable vector IO for the reader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
