wgtmac commented on code in PR #1143:
URL: https://github.com/apache/parquet-mr/pull/1143#discussion_r1330272179
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java:
##########
@@ -366,6 +366,10 @@ private void processChunk(ColumnChunkMetaData chunk,
ColumnIndex columnIndex = reader.readColumnIndex(chunk);
OffsetIndex offsetIndex = reader.readOffsetIndex(chunk);
+ BloomFilter bloomFilter = reader.readBloomFilter(chunk);
+ if (bloomFilter != null) {
+ writer.addBloomFilter(chunk.getPath().toDotString(), bloomFilter);
Review Comment:
If the column is masked to null, we should not keep the bloom filter.
Similarly, if the column is encrypted, we should make sure the bloom filter is
encrypted. Could you please add two tests to make sure they are handled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
