[
https://issues.apache.org/jira/browse/PARQUET-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770722#comment-17770722
]
ASF GitHub Bot commented on PARQUET-2358:
-----------------------------------------
sekikn opened a new pull request, #1161:
URL: https://github.com/apache/parquet-mr/pull/1161
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-2358
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
It doesn't need to add a new test since it's an upgrade of the testing tool
itself.
### Commits
- [x] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
> Upgrade japicmp-maven-plugin to 0.16.0
> --------------------------------------
>
> Key: PARQUET-2358
> URL: https://issues.apache.org/jira/browse/PARQUET-2358
> Project: Parquet
> Issue Type: Improvement
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Priority: Major
>
> Currently, running {{mvn verify}} with JDK 17 fails with the following error:
> {code}
> $ java -version
> openjdk version "17.0.8" 2023-07-18
> OpenJDK Runtime Environment Temurin-17.0.8+7 (build 17.0.8+7)
> OpenJDK 64-Bit Server VM Temurin-17.0.8+7 (build 17.0.8+7, mixed mode,
> sharing)
> $ mvn clean install -DskipTests
> ...
> [ERROR] Failed to execute goal
> com.github.siom79.japicmp:japicmp-maven-plugin:0.14.2:cmp (default) on
> project parquet-generator: Execution default of goal
> com.github.siom79.japicmp:japicmp-maven-plugin:0.14.2:cmp failed: An API
> incompatibility was encountered while executing
> com.github.siom79.japicmp:japicmp-maven-plugin:0.14.2:cmp:
> java.lang.ExceptionInInitializerError: null
> [ERROR] -----------------------------------------------------
> [ERROR] realm =
> plugin>com.github.siom79.japicmp:japicmp-maven-plugin:0.14.2
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> ...
> [ERROR] Number of foreign imports: 1
> [ERROR] import: Entry[import from realm ClassRealm[maven.api, parent: null]]
> [ERROR]
> [ERROR] -----------------------------------------------------
> [ERROR] : Unable to make protected final java.lang.Class
> java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int) throws
> java.lang.ClassFormatError accessible: module java.base does not "opens
> java.lang" to unnamed module @296703e4
> {code}
> [Upgrading japicmp-maven-plugin to 0.15+ will resolve this
> problem|https://github.com/siom79/japicmp/issues/275]. But the recent
> versions don't seem to be mature enough on addressing generics (its support
> was introduced since v0.17.0), so I'd like to upgrade it to a bit modest
> version for now, namely 0.16.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
