shangxinli commented on code in PR #1157:
URL: https://github.com/apache/parquet-mr/pull/1157#discussion_r1359912407
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java:
##########
@@ -341,7 +341,7 @@ public static void setMaxPaddingSize(Configuration conf,
int maxPaddingSize) {
conf.setInt(MAX_PADDING_BYTES, maxPaddingSize);
}
- private static int getMaxPaddingSize(Configuration conf) {
+ public static int getMaxPaddingSize(Configuration conf) {
Review Comment:
Changing method from private to public would need to add documentation and
unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
