ConeyLiu commented on code in PR #1183:
URL: https://github.com/apache/parquet-mr/pull/1183#discussion_r1381382668
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java:
##########
@@ -265,14 +265,9 @@ public void processBlocks() throws IOException {
}
private void processBlocksFromReader(IndexCache indexCache) throws
IOException {
- PageReadStore store = reader.readNextRowGroup();
- ColumnReadStoreImpl crStore = new ColumnReadStoreImpl(store, new
DummyGroupConverter(), schema, originalCreatedBy);
-
- int blockId = 0;
- while (store != null) {
- writer.startBlock(store.getRowCount());
Review Comment:
We don't need to get the row count from the `PageReadStore` since getting
the `PageReadStore` will force read the whole row group data into memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
