[ 
https://issues.apache.org/jira/browse/PARQUET-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790680#comment-17790680
 ] 

ASF GitHub Bot commented on PARQUET-2386:
-----------------------------------------

amousavigourabi opened a new pull request, #1209:
URL: https://github.com/apache/parquet-mr/pull/1209

   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Parquet 
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references 
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
       - This PR only refactors style, no logic is added or removed in any way 
shape or form
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In 
addition, my commits follow the guidelines from "[How to write a good git 
commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain Javadoc that 
explain what it does
     - Adds note in the PR template on the style checks
   
   ---
   
   This PR contains two commits, the first adds the style checks and 
configurations, the second applies these changes to the repository.




> More consistent code style in parquet-mr
> ----------------------------------------
>
>                 Key: PARQUET-2386
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2386
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-mr
>            Reporter: Atour Mousavi Gourabi
>            Assignee: Atour Mousavi Gourabi
>            Priority: Major
>
> The code style conventions used in parquet-mr are generally inconsistent and 
> unenforced. We might want to consider using linters such as Spotless and a 
> more extensive .editorconfig configuration.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to