I wouldn't say that I'm an expert but using bit manipulation in that case to me looks better as it shows how the different possibilities according to the spec are handled inside the code although casting might provide the same result. I didn't verify if the code is correct or not.
Kind regards Maruan Sahyoun Am 18.03.2010 um 18:34 schrieb Villu Ruusmann: > Hello there, > >> >> The following two open issues are currently targeted for 1.1.0: >> >> [PDFBOX-624] Misplaced text >> [PDFBOX-663] Ensuring non-null FontDescriptor for external TrueType fonts >> >> Both are unassigned. Can we postpone these to later releases? >> > > Both are "mine". They are solved (ie. the patchfiles are available) > and are waiting for approval by other project members. > > Andreas has looked at PDFBOX-624 lately. The patch looked somewhat > suspicious to him, because it employs simple Java casting instead of > more complex bit manipulation. Any more experts here? > > > VR
