[
https://issues.apache.org/jira/browse/PDFBOX-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901887#action_12901887
]
Jukka Zitting commented on PDFBOX-788:
--------------------------------------
> I think the caller, PrintPDF in our case, should be responsible of the
> PrintJob instantiation.
> The caller needs to tell the document: "print yourself on this printer with
> this jobname".
Isn't that already covered by the PDDocument.print(PrinterJob) method call? The
current code in PrintPDF is essentially:
PrinterJob printJob = PrinterJob.getPrinterJob();
...; // configure the printJob
document.print( printJob );
I'm not sure what extra value a setCurrentPrinterJob() setter would give us
here.
PS. In revision 988523 I committed the suggested improvement to explicitly set
the print job name. And in revision 988524 I simplified the PDDocument print
methods a bit by removing duplicate code.
> PrintPDF does not take the windows default printer orientation into account
> ---------------------------------------------------------------------------
>
> Key: PDFBOX-788
> URL: https://issues.apache.org/jira/browse/PDFBOX-788
> Project: PDFBox
> Issue Type: Bug
> Affects Versions: 1.2.1
> Environment: Windows XP at least
> Reporter: Christophe Borivant
> Assignee: Jukka Zitting
> Fix For: 1.3.0
>
> Attachments: PDDocument.patch, PDFBOX-788.diff
>
>
> We have 2 printers, the first one is defined to print in Portrait by default
> in Windows, the other one is defined to print in Landscape by default in
> Windows.
> PrintPDF does not take the default configuration into account.
> I wrote a little patch that seems to solve this bug
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
