Hi,

Maybe you can divide your commit in 4 smaller commits if they are
independent :
- one for the missing structured types
- one for the missing namespaces
- one for the reduced code duplication / increased code coverage /
simplified some unnecessary complex parts
- the last one for the preflight module

BR,
Eric

2012/7/25 Guillaume Bailleul <[email protected]>

> Hi,
>
> I worked on xmpbox and made many modifications :
> * reduced code duplication
> * implemented missing structured types
> * implemented missing namespaces
> * increased code coverage
> * simplified some unnecessary complex parts
>
> My patch is about 620kb long. It only have few impact on preflight and
> no impact on other modules.
>
> So I don't know if I commit it like a simple patch or if there is an
> other way to do it. Does someone have the answer to that question ?
>
> Thanks for your help,
>
> Guillaume
>

Reply via email to