[ 
https://issues.apache.org/jira/browse/PDFBOX-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Nistor updated PDFBOX-1460:
----------------------------------

    Attachment: patch.diff

patch
                
> wasted work in AbstractInvalidFileTester.validate()
> ---------------------------------------------------
>
>                 Key: PDFBOX-1460
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1460
>             Project: PDFBox
>          Issue Type: Bug
>    Affects Versions: 1.7.1
>            Reporter: Adrian Nistor
>              Labels: patch, performance
>         Attachments: patch.diff
>
>
> The problem appears in version 1.7.1 and in revision 1414788.  I
> attached a two-line patch that fixes it.
> In method "AbstractInvalidFileTester.validate", the loop over
> "result.getErrorsList()" should break immediately after "found" is set
> to "true" if "outputResult" is null.  All the iterations after "found"
> is set to "true" do not perform any useful work when "outputResult" is
> null, at best they just set "found" again to "true".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to