[ 
https://issues.apache.org/jira/browse/PDFBOX-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818972#comment-13818972
 ] 

Tilman Hausherr commented on PDFBOX-1777:
-----------------------------------------

Doesn't compile because the two variables are final. I also can't find a 
close() method for COSStream. (Or is your suggestion to create one?)

> memory leak in org.apache.pdfbox.cos.COSDocument
> ------------------------------------------------
>
>                 Key: PDFBOX-1777
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1777
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing
>    Affects Versions: 1.8.2
>         Environment: Windows 7, Netbeans 7.4
>            Reporter: Robert Scharpf
>            Priority: Minor
>              Labels: patch
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> org.apache.pdfbox.cos.COSDocument.close() does not close the streams and 
> causing therefore a growing memory leak. Supposed fix:
>  public void close() throws IOException {
> //        if (!closed) {
> //            scratchFile.close();
> //            if (tmpFile != null) {
> //                tmpFile.delete();
> //            }
> //            closed = true;
> //        }
>         // begin Robert Scharpf
>         closed = true;
>         if (scratchFile != null) {
>             try {
>                 scratchFile.close();
>             } catch (Exception e) {
>             }
>         }
>         scratchFile = null;
>         if (tmpFile != null) {
>             try {
>                 tmpFile.delete();
>             } catch (Exception e) {
>             }
>         }
>         tmpFile = null;
>         List<COSObject> list = getObjectsByType(COSName.OBJ_STM);
>         if (list != null) {
>             for (COSObject objStream : list) {
>                 COSStream stream = (COSStream) objStream.getObject();
>                 stream.close();
>             }
>         }
>         // end Robert Scharpf
>     }



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to