[
https://issues.apache.org/jira/browse/PDFBOX-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Hewson updated PDFBOX-1852:
--------------------------------
Attachment: TestRendering.java
Parallelized.java
Ok, then TestImageIOUtils into two is definitely the right thing. [~tilman]
I've updated TestRendering to use multithreading via a new test runner
ParallelParameterized which allows Parameterized tests to be run in parallel.
It sounds like multithreading is worth it on your build machine! JUnit's
Parameterized tests are now the preferred way to generate test cases
programmatically.
> [PATCH] Alternative patch to speed up TestImageIOUtils
> ------------------------------------------------------
>
> Key: PDFBOX-1852
> URL: https://issues.apache.org/jira/browse/PDFBOX-1852
> Project: PDFBox
> Issue Type: Improvement
> Affects Versions: 1.8.3, 2.0.0
> Reporter: John Hewson
> Priority: Minor
> Labels: patch, test
> Attachments: Parallelized.java, TestImageIOUtils.patch,
> TestRendering.java, jpeg_demo.pdf, png_demo.pdf, raw_image_demo.pdf
>
>
> This is an alternative to the PDFBOX-1850 patch to speed up TestImageIOUtils.
> Rather than using multi-threading, this patch reduces the scope of the
> TestImageIOUtils test. The purpose of TestImageIOUtils is to check
> thatImageIOUtils can write jpeg, bmp and wbmp files without throwing an
> exception. Looking at the mailing list archive
> http://mail-archives.apache.org/mod_mbox/pdfbox-commits/201112.mbox/%[email protected]%3E
> we can see that the original issue was that the JPEG compression
> configuration broke BMP writing. It is therefore sufficient to convert only a
> single PDF file to each of the output formats in order to test this.
> The test is not quite so simple though, as TestImageIOUtils is also used for
> processing embedded images in PDF files and so needs to be tested on
> appropriate PDF files, this is not something that the current test suite was
> actually doing. I've therefore added some test PDF files containing PNGs,
> JPEGs, and pixmaps. These are from libharu https://github.com/libharu/libharu
> and are under the ZLIB/LIBPNG license.
> Because TestImageIOUtils now only needs to be run on three files it takes
> around 2sec on my machine rather than over 30sec.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
