[ 
https://issues.apache.org/jira/browse/PDFBOX-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923602#comment-13923602
 ] 

Maruan Sahyoun commented on PDFBOX-1963:
----------------------------------------

John, there are others working on the lib and being dependent on a given 
functionality. When an outside API changes that’s typically discussed before 
and not simply committed. The fact that you can change it doesn’t mean that you 
have to because you think that its better, easier for the user … - if there is 
consensus to change it than it can be done,

I’m happy to think about and understand DPI. Which makes 2 people in this 
thread „experts“. You’ve not proven that there are any complains from the 
outside world that DPI is not being understood. So please revert that change. 
If you need an additional method add that but keep the current.

We all want PDFBox 2 to be better than PDFBox 1. And yes, there is crapy code 
in there. But the development is done jointly. 

> PDFImageWriter doesn't make use of PDFStreamEngine
> --------------------------------------------------
>
>                 Key: PDFBOX-1963
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1963
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 2.0.0
>            Reporter: John Hewson
>            Assignee: John Hewson
>             Fix For: 2.0.0
>
>
> PDFImageWriter is a subclass of PDFStreamEngine, however it never uses any of 
> its functionality, the writeImage methods could be marked as static and 
> behave in the same manner.
> The relationship between PDFImageWriter, RenderUtil, and ImageIOUtil no 
> longer matches its historical origins and needs to be refactored.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to