[ 
https://issues.apache.org/jira/browse/PDFBOX-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931431#comment-13931431
 ] 

Tilman Hausherr commented on PDFBOX-1975:
-----------------------------------------

Re 2: historically, as a user, I started by just saving the images with 
ImageIO.write(). As I started to look at the internal tests, I noticed that the 
files in the tests created by ImageIOUtils were better than mine, they had the 
resolution. That is the reason I started to use that code instead and improve 
it, e.g. with the writing of tailored TIFF images. The meta data isn't used 
within PDFBOX, so it means there are at least two people in the world who like 
the meta data, i.e. me and the one who created it initially :-)

So I'm for changing the functionality to the more logical behaviour (accepting 
a String for the filename), deprecating the current one, and use a new name, 
e.g. writeImageFile, or saveImage, or saveImageFile, or saveToImageFile, 
whetever.

> Improve TestImageIOUtils unit tests to check image resolution and compression
> -----------------------------------------------------------------------------
>
>                 Key: PDFBOX-1975
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1975
>             Project: PDFBox
>          Issue Type: Task
>          Components: Utilities
>    Affects Versions: 2.0.0
>            Reporter: Tilman Hausherr
>            Assignee: Tilman Hausherr
>            Priority: Minor
>              Labels: imageio, test, tiff
>             Fix For: 2.0.0
>
>
> Because of the problems with recent changes (see PDFBOX-1963), I will improve 
> the unit tests so that image resolution and compression is checked.
> I found out that JPEGs don't have a resolution, BMP had the wrong resolution. 
> The fault wasn't in the java TIFF writer as I thought before, it is in the 
> java PNG writer, which uses the PixelSize values wrongly, i.e. it interprets 
> them as "pixels per mm" instead of "mm per pixel" as per specification. The 
> JPEG writer throws an exception "JFIF APP0 must be first marker after SOI". 
> The BMP writer can set the resolution, but the BMP reader doesn't read it.
> (Some of this might be different depending on the version)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to