[ 
https://issues.apache.org/jira/browse/PDFBOX-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003627#comment-14003627
 ] 

Tilman Hausherr commented on PDFBOX-1922:
-----------------------------------------

COSDocument.java has this:
{code}
    public void setVersion( float versionValue )
    {
        // update header string
        if (versionValue != version) 
        {
            headerString = headerString.replaceFirst(String.valueOf(version), 
String.valueOf(versionValue));
        }
        version = versionValue;
    }
{code}

So it does two things, set the version and set the headerString. My first Idea 
would be to remove the setting of the headerString, because this is 1. a side 
effect and 2. already done elsewhere. But this was inserted in 2011 by [~lehmi] 
as part of PDFBOX-879 so I wonder if I will break something by removing this.

> NonSequentialParser not reading version in header and trailer
> -------------------------------------------------------------
>
>                 Key: PDFBOX-1922
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1922
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing
>    Affects Versions: 1.8.4, 1.8.5, 1.8.6, 2.0.0
>            Reporter: Tim Allison
>            Assignee: Tilman Hausherr
>            Priority: Minor
>             Fix For: 1.8.6, 2.0.0
>
>         Attachments: testAnnotations.pdf
>
>
> On older pdf files, the NonSequentialParser returns a different PDFVersion 
> than the traditional parser via the call: 
> document.getDocument().getVersion().  
> I think this is because NonSequentialParser is not reading the header but 
> relying on the default 1.4 if no version is found in the trailer.
> Many apologies if this is a duplicate.  I feel like I've seen this issue 
> elsewhere, but I can't track it down.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to