[ https://issues.apache.org/jira/browse/PDFBOX-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034373#comment-14034373 ]
Petr Slaby commented on PDFBOX-2145: ------------------------------------ Speaking about clean up - the way my Eclipse is configured, I get about 200 warnings on pdfbox code - unused imports, potential null pointer access, redundant null check, undocumented empty blocks, unnecessary semicolon - to name but a few. Usage of such warning is a matter of personal taste or team rules - what are yours? Do you intend to clean up at least some of these warnings? Mostly, this does not bring any real improvements, but still. E.g. following the warnings in PDSeedValue reveals a duplicated null check which does not make any obvious sense. > Clean up PDFStreamEngine and PDFTextStripper > -------------------------------------------- > > Key: PDFBOX-2145 > URL: https://issues.apache.org/jira/browse/PDFBOX-2145 > Project: PDFBox > Issue Type: Improvement > Components: Text extraction > Affects Versions: 2.0.0 > Reporter: John Hewson > Assignee: John Hewson > Priority: Minor > > PDFStreamEngine and PDFTextStripper don't really meet our coding conventions > and have several unused methods and deprecated code which can safely be > removed. -- This message was sent by Atlassian JIRA (v6.2#6252)