[ 
https://issues.apache.org/jira/browse/PDFBOX-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057880#comment-14057880
 ] 

Tilman Hausherr commented on PDFBOX-2117:
-----------------------------------------

The images are not identical, but they look fine. If I understand correctly, 
you calculated values along a line. So the result might not be the same because 
the coordinates of the axis don't start and end exactly on a pixel - correct? I 
didn't check all the diffs (will do later) but it is probably all fine.

It is faster for me (about 50 - 100%) but in total, my test suite is maybe just 
1 minute faster, this might be because I don't have many axial renderings in it.

[~pslabycz] could you please try [her 
change|https://bitbucket.org/xinshu/pdfbox/raw/61564cd86f540c92782ab6b9f9885be02cbcb9b7/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/AxialShadingContext.java]
 and tell what times you get with the files you tested on June 5th?

[~xinshu] sorry, I didn't include PDFunction last time. I'll test that next.

> AxialShadingContext is slow
> ---------------------------
>
>                 Key: PDFBOX-2117
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2117
>             Project: PDFBox
>          Issue Type: Sub-task
>          Components: Rendering
>            Reporter: Petr Slaby
>         Attachments: 000001_MTEXT_CS6.pdf, AxialShading.patch, 
> AxialShading1.patch, AxialShadingContext.java.getrgbimage, 
> Shading2Function2.pdf, Shading2Function2.ps, Shading2Function2text.pdf, 
> asy-shade.pdf, color_gradient.pdf, shading_pattern.pdf
>
>
> AxialShadingContext#getRaster() is on top of profiler hot spots in documents 
> that use an axial shading. Inside it, the slowest part is calling 
> PDColorSpaceRGB#toRGB() and PDFunctionType3#eval() (in this order).
>   



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to