[
https://issues.apache.org/jira/browse/PDFBOX-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081209#comment-14081209
]
Tilman Hausherr commented on PDFBOX-2117:
-----------------------------------------
The problem was that the intermediate variable calculated has a "valid" range
of 0..1, i.e. the value is independent of the /Domain. So the special handling
for values outside of the range must work with 0 and 1 and not with the
/Domain, because of that we got input values higher than the array.
See https://svn.apache.org/r1614946 .
Your last change was correct, but only if I would also insert another line that
was deleted in optimization. However after adding it and deleting everything
double in the formula, at the end I got exactly the code that you had before
this week. In other words - I did NOT take your 00a0d9a commit.
> AxialShadingContext is slow
> ---------------------------
>
> Key: PDFBOX-2117
> URL: https://issues.apache.org/jira/browse/PDFBOX-2117
> Project: PDFBox
> Issue Type: Sub-task
> Components: Rendering
> Affects Versions: 1.8.6, 1.8.7, 2.0.0
> Reporter: Petr Slaby
> Assignee: Shaola Ren
> Labels: shading, shadingpattern
> Fix For: 2.0.0
>
> Attachments: 000001_MTEXT_CS6.pdf, AxialShading.patch,
> AxialShading1.patch, AxialShadingContext.java.getrgbimage,
> GWG061_Shading_x1a.pdf, GWG061_Shading_x1a.pdf-1.png,
> GWG061_Shading_x1a.pdf-1.png-diff.png, PDFBOX-2117-068519.pdf,
> PDFBOX-2117-068519.pdf-2-bad.png, PDFBOX-2117-068519.pdf-2-good.png,
> Shading2Function2.pdf, Shading2Function2.ps, Shading2Function2text.pdf,
> asy-shade.pdf, color_gradient.pdf, shading_pattern.pdf
>
>
> AxialShadingContext#getRaster() is on top of profiler hot spots in documents
> that use an axial shading. Inside it, the slowest part is calling
> PDColorSpaceRGB#toRGB() and PDFunctionType3#eval() (in this order).
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
