[ 
https://issues.apache.org/jira/browse/PDFBOX-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129830#comment-14129830
 ] 

Andreas Lehmkühler commented on PDFBOX-2337:
--------------------------------------------

{quote}
Do we really need a ICLA / CCLA in this case?
{quote}
There are no explicit rules to decide that, just a rule of thumb: only 
substantial changes require signing a CLA. IMO an example on how to use PDFBox 
doesn't qualify for that. It simply uses PDFBox and doesn't add any new 
features.

{quote}
The Apache header you've used is for ASF projects, e.g. "Licensed to the Apache 
Software Foundation (ASF) under one or more contributor license agreements." 
isn't true unless you've signed a CLA and contributed this code to Apache.
{quote}
Good catch. That should be changed to the more general version of the AL 2.0 
which can be found [here|http://apache.org/licenses/LICENSE-2.0] in the 
APPENDIX section at the end.

{quote}
I’d also vote for taking this sample as is and include that in 1.8.x 
{quote}
+1, we agreed to stop adding any new features to the 1.8 branch. But as this is 
just an example I don't see any reason not to add it.

> Add an example for highlighting text based on a string 
> -------------------------------------------------------
>
>                 Key: PDFBOX-2337
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2337
>             Project: PDFBox
>          Issue Type: New Feature
>          Components: Utilities
>            Reporter: Joël Kuiper
>
> An often heard request is to be able to highlight a certain text within a PDF 
> programmatically, similar to the highlight functionality in Acrobat or 
> Preview.app.
> The actual implementation of this functionality is trickier than it appears, 
> since it requires the calculation of bouding boxes from TextPositions. 
> A example class may help people with implementing this (common) 
> functionality. 
> (see for example this discussion 
> https://mail-archives.apache.org/mod_mbox/pdfbox-users/201409.mbox/%3CC8340BB9-E299-4A76-A50B-6155504A0D5B%40joelkuiper.eu%3E)
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to