[ 
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289601#comment-14289601
 ] 

Tilman Hausherr commented on PDFBOX-2576:
-----------------------------------------

About [ https://svn.apache.org/r1654283 ]: While looking at a SonarQube report, 
I noticed that in Type3fontvalidator.java the local variable "encoding" was 
written but not used, and that there were two seemingly useless methods. 
Further investigation back in time showed that checks that were in the initial 
version were somehow lost in refactoring (there was the expectation that 
DictionaryEncoding would throw an IOException for bad /Encoding entries, but it 
isn't so anymore). I've thus restored the checking code from 2012.

> Improve code quality
> --------------------
>
>                 Key: PDFBOX-2576
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2576
>             Project: PDFBox
>          Issue Type: Task
>    Affects Versions: 2.0.0
>            Reporter: Tilman Hausherr
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to