[
https://issues.apache.org/jira/browse/PDFBOX-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327109#comment-14327109
]
Andrea Vacondio commented on PDFBOX-2689:
-----------------------------------------
{quote}
I noticed that you don't have a Page.getDuration(), was this intended?
{quote}
It's just a number and I thought it wasn't that interesting to add a method for
that and it can be accessed through the getCOSObject, on the other hand in
getTransition the dictionary needs to be wrapped by a PDTransition and it
seemed a little more interesting to add a method there, anyway I wasn't really
sure, it was an arbitrary decision.
{quote}
Why name a variable in the test "victim"? This is kindof sad
{quote}
Habit, I call them that since as far as I can remember... I guess it's the
because it's the victim/target of the unit test :)
> Implement page transitions
> --------------------------
>
> Key: PDFBOX-2689
> URL: https://issues.apache.org/jira/browse/PDFBOX-2689
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
> Affects Versions: 2.0.0
> Reporter: Andrea Vacondio
> Priority: Minor
> Labels: transitions
> Fix For: 2.0.0
>
> Attachments: transitions.diff, transitions_test.pdf
>
>
> I implemented page transitions as described in the spec 32000-1:2008 chapter
> 12.4.4.1
> I'm attaching the diff file and the test pdf document. Feel free to use it
> and/or change it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
