[ 
https://issues.apache.org/jira/browse/PDFBOX-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372595#comment-14372595
 ] 

ASF subversion and git services commented on PDFBOX-2719:
---------------------------------------------------------

Commit 1668206 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1668206 ]

PDFBOX-2719 don't set signature always at last page

> The addSignature() method always set the visual signature on the last page of 
> the PDF
> -------------------------------------------------------------------------------------
>
>                 Key: PDFBOX-2719
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2719
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Signing
>    Affects Versions: 2.0.0
>            Reporter: Cyril Bremaud
>            Assignee: Maruan Sahyoun
>              Labels: easyfix
>             Fix For: 2.0.0
>
>
> The {{addSignature()}} method always set the visual signature on the last 
> page of the PDF.
> This is certainly due to the following lines in {{PDDocument}} class :
> {code:title=PDDocument.java|borderStyle=solid}
> ...
> int startIndex = Math.max(Math.min(options.getPage(), 0), pageCount - 1);
> PDPage page = catalog.getPages().get(startIndex);
> ...
> {code}
> I think {{Math.min}} and {{Math.max}} have been inverted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to