[
https://issues.apache.org/jira/browse/PDFBOX-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578427#comment-14578427
]
Glenn Adams commented on PDFBOX-2820:
-------------------------------------
That seems reasonable. Since I am presently only using the fontbox artifact,
and since there was already an existing checkstyle rules file, I though it
reasonable to start there.
If you like, I could submit a new patch that covers all the sub-projects
instead of just fontbox. Though I might have to disable more rules if I
encounter significant violations of the rules expressed in the current patch.
I was hoping to introduce checkstyle in a couple of steps: (1) turn on CS with
minimal changes to rules and code; (2) re-enable rules and fix code for
warnings. What approach would the project prefer?
> Configure and enable checkstyle for fontbox.
> --------------------------------------------
>
> Key: PDFBOX-2820
> URL: https://issues.apache.org/jira/browse/PDFBOX-2820
> Project: PDFBox
> Issue Type: Improvement
> Components: FontBox
> Reporter: Glenn Adams
> Attachments: fontbox.checkstyle.patch
>
>
> The fontbox sub-tree contains an apparently old checkstyle configuration
> file, which no longer works for checkstyle 5 or later. I'm not sure if it is
> being used or not. In any case, it would be useful (IMO) to update this
> configuration and enable the use of checkstyle:check in the validate phase
> and checkstyle:checkstyle in the site phase. The former goal is useful for
> inducing a fail at build time, while the latter is useful for report
> generation.
> I will attach a patch to this issue that implements the above. For the time
> being, I've temporarily disabled a few checks due to their producing a rather
> large number of warnings. Once this initial patch is merged, I will post
> another patch that re-enables the checks and fixes existing warnings.
> Note that the current checkstyle plugin (version 2.15) employs checkstyle
> 6.1.1 by default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
