[
https://issues.apache.org/jira/browse/PDFBOX-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066255#comment-15066255
]
Benjamin Gamard commented on PDFBOX-3163:
-----------------------------------------
I tend to agree with [~tilman], yet another external dependency for such a
simple task seems overkill. We are talking 30 LOC max here.
> PDImageXObject.createFromFile should relies on header bytes
> -----------------------------------------------------------
>
> Key: PDFBOX-3163
> URL: https://issues.apache.org/jira/browse/PDFBOX-3163
> Project: PDFBox
> Issue Type: Improvement
> Components: PDModel
> Affects Versions: 2.0.0
> Reporter: Benjamin Gamard
> Attachments: 3163.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> PDImageXObject.createFromFile currently relies on file extension to select
> the correct factory.
> Often, file extension is not set or not correct.
> It should be better to use the first bytes.
> I did something similar here if it can helps:
> https://github.com/sismics/docs/blob/master/docs-core/src/main/java/com/sismics/util/mime/MimeTypeUtil.java#L26
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
