[
https://issues.apache.org/jira/browse/PDFBOX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293172#comment-15293172
]
Tilman Hausherr commented on PDFBOX-3355:
-----------------------------------------
[[email protected]] please give feedback that the change works for you. I
did it differently than proposed (although your solution is also correct) to
have both make...Label methods return lower case. IMHO {{makeLetterLabel}}
returning upper case and {{makeRomanLabel}} returning lower case was confusing
and caused the bug.
> PDPageLabels.getLabelsByPageIndices() returns Uppercase letters for style a
> ---------------------------------------------------------------------------
>
> Key: PDFBOX-3355
> URL: https://issues.apache.org/jira/browse/PDFBOX-3355
> Project: PDFBox
> Issue Type: Bug
> Components: PDModel
> Affects Versions: 2.0.1
> Environment: Windows Computer
> Reporter: Carlos Cabral
> Priority: Trivial
> Labels: easyfix
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> For the style 'a' the Method getLabelsByPageIndices returns uppercase due to
> the method LabelGenerator.makeLetterLabel always returns uppercase. Then the
> method LabelGenerator.getNumber shoule be changed from:
> {code}
> } else if (PDPageLabelRange.STYLE_LETTERS_LOWER.equals(style)) {
> return makeLetterLabel(pageIndex);
> } else if (PDPageLabelRange.STYLE_LETTERS_UPPER.equals(style)) {
> return makeLetterLabel(pageIndex).toUpperCase();
> }
> {code}
> to:
> {code}
> } else if (PDPageLabelRange.STYLE_LETTERS_LOWER.equals(style)) {
> return makeLetterLabel(pageIndex).toLowerCase();
> } else if (PDPageLabelRange.STYLE_LETTERS_UPPER.equals(style)) {
> return makeLetterLabel(pageIndex);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
